2a5d20c138
The TreeWalk filtering classes need to support the three different
meanings of the return value the path comparison generates.
A new path comparison method (isPathMatch) is created with
three distinct return values (isPathPrefix use value '0' to
encode two of these) which will makes it possible for the logical
operators (especially NOT) to aggregate a correct verdict.
A filter like: AND(Path("path"), NOT(Path("path/to/other")))
Should filter out 'path/to/other/file', but not 'path/to/my/file'.
The path-limiting feature when testing path/to/my/file, would
result to run test for the following paths:
path
path/to
path/to/my
path/to/my/file
isPathPrefix('path/to/other') will return '0' for the first two
and since there is no way for NOT to distinguish between an exact
match and a match indicating that the tested path is a 'parent',
it will incorrectly return false and thus remove everything below
'path' immediately.
isPathMatch has a distinguished value for 'parent' matches that
will be preserved through the logic operators and should not
cause an over-eager removal of paths.
The functionality of isPathPrefix is required by other parts
and is untouched.
Unit tests are included to ensure that the logical functionality
is correct and can be preserved.
Change-Id: Ice2ca9406f09f1b179569e99b86a0e5d77baa20d
Signed-off-by: Magnus Vigerlöf <magnus.vigerlof@gmail.com>
|
||
|---|---|---|
| .. | ||
| .settings | ||
| META-INF | ||
| exttst/org/eclipse/jgit | ||
| src/org/eclipse/jgit/lib | ||
| tst/org/eclipse/jgit | ||
| tst-rsrc | ||
| .classpath | ||
| .gitignore | ||
| .project | ||
| BUCK | ||
| build.properties | ||
| org.eclipse.jgit.core--All-Tests (Java 8) (de).launch | ||
| org.eclipse.jgit.core--All-Tests (Java 8).launch | ||
| org.eclipse.jgit.core--All-Tests.launch | ||
| org.eclipse.jgit.test-WalkEncryptionTest-Proxy.launch | ||
| org.eclipse.jgit.test-WalkEncryptionTest.launch | ||
| plugin.properties | ||
| pom.xml | ||