jgit/org.eclipse.jgit
Matthias Sohn d9e957dc24 SshSupport#runSshCommand: don't throw exception in finally block
The CommandFailedException which was thrown in finally block is silently
discarded [1]. Refactor this method to throw the exception after the
finally block.

This fixes the warning "Null comparison always yields false: The
variable failure can only be null at this location".

[1] https://wiki.sei.cmu.edu/confluence/display/java/ERR04-J.+Do+not+complete+abruptly+from+a+finally+block
https://docs.oracle.com/javase/specs/jls/se8/html/jls-14.html#jls-14.20.2

Change-Id: Idbfc303d9c9046ab9a43e0d4c6d65d325bdaf0ed
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2020-01-06 11:40:04 +01:00
..
.settings Enhance WindowCache statistics 2019-12-08 01:09:24 +01:00
META-INF Prepare 5.1.13-SNAPSHOT builds 2019-10-02 00:40:49 +02:00
findBugs [findBugs] Silence warning about Transport initialization 2012-09-14 00:01:47 +02:00
resources/org/eclipse/jgit Fix wrong placeholder index in error message packInaccessible 2019-09-07 01:19:07 +02:00
src/org/eclipse/jgit SshSupport#runSshCommand: don't throw exception in finally block 2020-01-06 11:40:04 +01:00
.classpath Change JGit minimum execution environment to JavaSE-1.8 2016-09-20 11:32:36 +02:00
.fbprefs
.gitignore
.project
BUILD Bazel: Add fixes for --incompatible_load_java_rules_from_bzl 2019-09-07 15:36:11 +09:00
about.html SHA-1: collision detection support 2017-02-28 16:38:43 -08:00
build.properties
plugin.properties Remove incubation marker 2011-05-31 22:53:53 +02:00
pom.xml Prepare 5.1.13-SNAPSHOT builds 2019-10-02 00:40:49 +02:00