From 0162a0868c18dc94f8d89c0c95bd89ebd63c0b41 Mon Sep 17 00:00:00 2001 From: r00ster91 Date: Tue, 1 Nov 2022 18:26:04 +0100 Subject: [PATCH] isHex, isAlphanumeric: prong reorder On x86 interestingly I can see a reduction in codesize by 1 instruction with this. While not necessarily faster, it might still reduce codesize a bit and this ordering is also more logical because it follows ASCII table order. Rust's std uses this ordering too. See https://zig.godbolt.org/z/PqodY8YqY for the difference. --- lib/std/ascii.zig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/std/ascii.zig b/lib/std/ascii.zig index 78c4124eca..facabaf795 100644 --- a/lib/std/ascii.zig +++ b/lib/std/ascii.zig @@ -91,7 +91,7 @@ pub const control_code = struct { /// Returns whether the character is alphanumeric: A-Z, a-z, or 0-9. pub fn isAlphanumeric(c: u8) bool { return switch (c) { - 'A'...'Z', 'a'...'z', '0'...'9' => true, + '0'...'9', 'A'...'Z', 'a'...'z' => true, else => false, }; } @@ -167,7 +167,7 @@ pub fn isUpper(c: u8) bool { /// Returns whether the character is a hexadecimal digit: A-F, a-f, or 0-9. pub fn isHex(c: u8) bool { return switch (c) { - 'A'...'F', 'a'...'f', '0'...'9' => true, + '0'...'9', 'A'...'F', 'a'...'f' => true, else => false, }; }