motiejus/zig
1
Fork 0
Code Releases Activity

stage1: fix f80 size and alignment on x86 and arm

Browse Source 
* F80Repr extern struct needs no explicit padding; let's match the
   target padding.
 * stage2: fix lowering of f80 constants.
 * stage1: decide ABI size and alignment of f80 based on alignment of
   u64. x86 has alignof u64 equal to 4 but arm has it as 8.
 * stage2: fix Value.floatReadFromMemory to use F80Repr
This commit is contained in:
Andrew Kelley
2022-02-10 17:36:31 -07:00
committed by Jakub Konka
parent f293fbbeaf
commit 166db1a3ed
4 changed files with 67 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/stage1/codegen.cpp
View File

@@ -9429,17 +9429,29 @@ static void define_builtin_types(CodeGen *g) {
{
ZigType *entry = new_type_table_entry(ZigTypeIdFloat);
unsigned u64_alignment = LLVMABIAlignmentOfType(g->target_data_ref, LLVMInt64Type());
if (u64_alignment >= 8) {
entry->size_in_bits = 128;
entry->abi_size = 16;
entry->abi_align = 16;
} else if (u64_alignment >= 4) {
entry->size_in_bits = 96;
entry->abi_size = 12;
entry->abi_align = 4;
} else {
entry->size_in_bits = 80;
entry->abi_size = 10;
entry->abi_align = 2;
}
if (target_has_f80(g->zig_target)) {
entry->llvm_type = LLVMX86FP80Type();
} else {
// We use i128 here instead of x86_fp80 because on targets such as arm,
// We use an int here instead of x86_fp80 because on targets such as arm,
// LLVM will give "ERROR: Cannot select" for any instructions involving
// the x86_fp80 type.
entry->llvm_type = get_int_type(g, false, 128)->llvm_type;
entry->llvm_type = get_int_type(g, false, entry->size_in_bits)->llvm_type;
}
entry->size_in_bits = 8 * 16;
entry->abi_size = 16; // matches LLVMABISizeOfType(LLVMX86FP80Type())
entry->abi_align = 16; // matches LLVMABIAlignmentOfType(LLVMX86FP80Type())
buf_init_from_str(&entry->name, "f80");
entry->data.floating.bit_count = 80;