From 1ec0261518a8a0e302ebba28c96c4956ba323ce7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nathana=C3=ABl=20Courant?= Date: Mon, 7 Dec 2020 23:27:37 +0100 Subject: [PATCH] Fix general purpose allocator incorrectly modifying total_requested_bytes in some cases --- lib/std/heap/general_purpose_allocator.zig | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/std/heap/general_purpose_allocator.zig b/lib/std/heap/general_purpose_allocator.zig index e301d20811..489da19a6f 100644 --- a/lib/std/heap/general_purpose_allocator.zig +++ b/lib/std/heap/general_purpose_allocator.zig @@ -517,7 +517,11 @@ pub fn GeneralPurposeAllocator(comptime config: Config) type { second_free_stack_trace, }); if (new_size == 0) { - // Recoverable. + // Recoverable. Restore self.total_requested_bytes if needed, as we + // don't return an error value so the errdefer above does not run. + if (config.enable_memory_limit) { + self.total_requested_bytes = prev_req_bytes; + } return @as(usize, 0); } @panic("Unrecoverable double free");