motiejus/zig
1
Fork 0
Code Releases Activity

stage1: remove buggy "unable to inline function" compile error

Browse Source 
We still want this compile error but I'm giving up on implementing it
correctly in stage1. It's been buggy and has false positives sometimes.

I left the test cases there, but commented out, so that when we go
through the stage1 compile error cases and get coverage for them in
stage2 we can reactivate the test cases.

closes #2154
This commit is contained in:
Andrew Kelley
2020-08-15 09:53:39 -07:00
parent 0f3f96c850
commit 2cd19c05d0
2 changed files with 26 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
test/compile_errors.zig
View File

@@ -6151,32 +6151,33 @@ pub fn addCases(cases: *tests.CompileErrorContext) void {
"tmp.zig:2:15: error: expected error union type, found '?i32'",
});
cases.add("inline fn calls itself indirectly",
\\export fn foo() void {
\\ bar();
\\}
\\inline fn bar() void {
\\ baz();
\\ quux();
\\}
\\inline fn baz() void {
\\ bar();
\\ quux();
\\}
\\extern fn quux() void;
, &[_][]const u8{
"tmp.zig:4:1: error: unable to inline function",
});
// TODO test this in stage2, but we won't even try in stage1
//cases.add("inline fn calls itself indirectly",
// \\export fn foo() void {
// \\ bar();
// \\}
// \\inline fn bar() void {
// \\ baz();
// \\ quux();
// \\}
// \\inline fn baz() void {
// \\ bar();
// \\ quux();
// \\}
// \\extern fn quux() void;
//, &[_][]const u8{
// "tmp.zig:4:1: error: unable to inline function",
//});
cases.add("save reference to inline function",
\\export fn foo() void {
\\ quux(@ptrToInt(bar));
\\}
\\inline fn bar() void { }
\\extern fn quux(usize) void;
, &[_][]const u8{
"tmp.zig:4:1: error: unable to inline function",
});
//cases.add("save reference to inline function",
// \\export fn foo() void {
// \\ quux(@ptrToInt(bar));
// \\}
// \\inline fn bar() void { }
// \\extern fn quux(usize) void;
//, &[_][]const u8{
// "tmp.zig:4:1: error: unable to inline function",
//});
cases.add("signed integer division",
\\export fn foo(a: i32, b: i32) i32 {