From 3bcdca07a37d29256c56c2b681d43d74cd0f88b5 Mon Sep 17 00:00:00 2001 From: WillLillis Date: Sun, 29 Sep 2024 20:55:08 -0400 Subject: [PATCH] fix: print correct number of provided arguments in min/max error message --- lib/std/zig/AstGen.zig | 2 +- test/cases/compile_errors/minmax_missing_args.zig | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 test/cases/compile_errors/minmax_missing_args.zig diff --git a/lib/std/zig/AstGen.zig b/lib/std/zig/AstGen.zig index 96be562796..f1388dad24 100644 --- a/lib/std/zig/AstGen.zig +++ b/lib/std/zig/AstGen.zig @@ -9142,7 +9142,7 @@ fn minMax( ) InnerError!Zir.Inst.Ref { const astgen = gz.astgen; if (args.len < 2) { - return astgen.failNode(node, "expected at least 2 arguments, found 0", .{}); + return astgen.failNode(node, "expected at least 2 arguments, found {}", .{args.len}); } if (args.len == 2) { const tag: Zir.Inst.Tag = switch (op) { diff --git a/test/cases/compile_errors/minmax_missing_args.zig b/test/cases/compile_errors/minmax_missing_args.zig new file mode 100644 index 0000000000..85a602fd40 --- /dev/null +++ b/test/cases/compile_errors/minmax_missing_args.zig @@ -0,0 +1,9 @@ +comptime { _ = @min(1); } +comptime { _ = @max(1); } + +// error +// backend=stage2 +// target=native +// +// :1:16: error: expected at least 2 arguments, found 1 +// :2:16: error: expected at least 2 arguments, found 1