http: fix fetching a github release

* Support different keep alive defaults with different http versions.
 * Fix incorrect usage of `copyBackwards`, which copies in a backwards
   direction allowing data to be moved forward in a buffer, not
   backwards in a buffer.
This commit is contained in:
Jacob Young
2024-02-26 17:04:28 +01:00
committed by Andrew Kelley
parent 8775d8bbce
commit 4e2570baaf
4 changed files with 32 additions and 27 deletions

View File

@@ -430,7 +430,7 @@ pub const Response = struct {
/// Points into the user-provided `server_header_buffer`.
content_disposition: ?[]const u8 = null,
keep_alive: bool = false,
keep_alive: bool,
/// If present, the number of bytes in the response body.
content_length: ?u64 = null,
@@ -477,6 +477,10 @@ pub const Response = struct {
res.version = version;
res.status = status;
res.reason = reason;
res.keep_alive = switch (version) {
.@"HTTP/1.0" => false,
.@"HTTP/1.1" => true,
};
while (it.next()) |line| {
if (line.len == 0) return;
@@ -684,9 +688,10 @@ pub const Request = struct {
req.response.parser.reset();
req.response = .{
.version = undefined,
.status = undefined,
.reason = undefined,
.version = undefined,
.keep_alive = undefined,
.parser = req.response.parser,
};
}
@@ -1564,9 +1569,10 @@ pub fn open(
.redirect_behavior = options.redirect_behavior,
.handle_continue = options.handle_continue,
.response = .{
.version = undefined,
.status = undefined,
.reason = undefined,
.version = undefined,
.keep_alive = undefined,
.parser = proto.HeadersParser.init(options.server_header_buffer),
},
.headers = options.headers,