AstGen: fix loop result locations
The main problem was that the loop body was treated as an expression that was one of the peer result values of a loop, when in reality the loop body is noreturn and only the `break` operands are the result values of loops. This was solved by introducing an override that prevents rvalue() from emitting a store to result location instruction for loop bodies. An orthogonal change also included in this commit is switching `elem_val` index expressions to using `coerced_ty` and doing the coercion to `usize` inside `Sema`, resulting in smaller ZIR (since the cast becomes implied). I also changed the break operand expression to use `reachableExpr`, introducing a new compile error for double break. This makes a few more behavior tests pass for `while` and `for` loops.
This commit is contained in:
@@ -5042,6 +5042,17 @@ pub fn addCases(ctx: *TestContext) !void {
|
||||
"tmp.zig:2:12: note: control flow is diverted here",
|
||||
});
|
||||
|
||||
ctx.objErrStage1("unreachable code - double break",
|
||||
\\export fn a() void {
|
||||
\\ const b = blk: {
|
||||
\\ break :blk break :blk @as(u32, 1);
|
||||
\\ };
|
||||
\\}
|
||||
, &[_][]const u8{
|
||||
"tmp.zig:3:9: error: unreachable code",
|
||||
"tmp.zig:3:20: note: control flow is diverted here",
|
||||
});
|
||||
|
||||
ctx.objErrStage1("chained comparison operators",
|
||||
\\export fn a(value: u32) bool {
|
||||
\\ return 1 < value < 1000;
|
||||
|
||||
Reference in New Issue
Block a user