motiejus/zig
1
Fork 0
Code Releases Activity

std.builtin: rename Type.Fn's args to params

Browse Source 
This was a poor naming choice; these are parameters, not arguments.
Parameters specify what kind of arguments are expected, whereas the arguments are the actual values passed.
This commit is contained in:
r00ster91
2022-12-13 21:54:04 +01:00
parent 20d3fd901e
commit 7350ea3e2d
14 changed files with 44 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/behavior/bugs/12885.zig
View File

@@ -15,7 +15,7 @@ test "ErrorSet comptime_field_ptr" {
}
const fn_info = .{
.args = [_]builtin.Type.Fn.Param{
.params = [_]builtin.Type.Fn.Param{
.{ .is_generic = false, .is_noalias = false, .type = u8 },
},
};
@@ -26,7 +26,7 @@ const Bar = @Type(.{
.is_generic = false,
.is_var_args = false,
.return_type = void,
.args = &fn_info.args,
.params = &fn_info.params,
},
});
test "fn comptime_field_ptr" {

8
test/behavior/reflection.zig
View File

@@ -9,10 +9,10 @@ test "reflection: function return type, var args, and param types" {
const info = @typeInfo(@TypeOf(dummy)).Fn;
try expect(info.return_type.? == i32);
try expect(!info.is_var_args);
try expect(info.args.len == 3);
try expect(info.args[0].type.? == bool);
try expect(info.args[1].type.? == i32);
try expect(info.args[2].type.? == f32);
try expect(info.params.len == 3);
try expect(info.params[0].type.? == bool);
try expect(info.params[1].type.? == i32);
try expect(info.params[2].type.? == f32);
}
}

2
test/behavior/type.zig
View File

@@ -512,7 +512,7 @@ test "Type.Fn" {
.is_generic = false,
.is_var_args = false,
.return_type = void,
.args = &.{
.params = &.{
.{ .is_generic = false, .is_noalias = false, .type = c_int },
.{ .is_generic = false, .is_noalias = false, .type = some_ptr },
},

34
test/behavior/type_info.zig
View File

@@ -365,7 +365,7 @@ fn testFunction() !void {
try expect(fn_info.Fn.alignment > 0);
try expect(fn_info.Fn.calling_convention == .C);
try expect(!fn_info.Fn.is_generic);
try expect(fn_info.Fn.args.len == 2);
try expect(fn_info.Fn.params.len == 2);
try expect(fn_info.Fn.is_var_args);
try expect(fn_info.Fn.return_type.? == usize);
const fn_aligned_info = @typeInfo(@TypeOf(typeInfoFooAligned));
@@ -377,31 +377,31 @@ extern fn typeInfoFooAligned(a: usize, b: bool, ...) align(4) callconv(.C) usize
test "type info: generic function types" {
const G1 = @typeInfo(@TypeOf(generic1));
try expect(G1.Fn.args.len == 1);
try expect(G1.Fn.args[0].is_generic == true);
try expect(G1.Fn.args[0].type == null);
try expect(G1.Fn.params.len == 1);
try expect(G1.Fn.params[0].is_generic == true);
try expect(G1.Fn.params[0].type == null);
try expect(G1.Fn.return_type == void);
const G2 = @typeInfo(@TypeOf(generic2));
try expect(G2.Fn.args.len == 3);
try expect(G2.Fn.args[0].is_generic == false);
try expect(G2.Fn.args[0].type == type);
try expect(G2.Fn.args[1].is_generic == true);
try expect(G2.Fn.args[1].type == null);
try expect(G2.Fn.args[2].is_generic == false);
try expect(G2.Fn.args[2].type == u8);
try expect(G2.Fn.params.len == 3);
try expect(G2.Fn.params[0].is_generic == false);
try expect(G2.Fn.params[0].type == type);
try expect(G2.Fn.params[1].is_generic == true);
try expect(G2.Fn.params[1].type == null);
try expect(G2.Fn.params[2].is_generic == false);
try expect(G2.Fn.params[2].type == u8);
try expect(G2.Fn.return_type == void);
const G3 = @typeInfo(@TypeOf(generic3));
try expect(G3.Fn.args.len == 1);
try expect(G3.Fn.args[0].is_generic == true);
try expect(G3.Fn.args[0].type == null);
try expect(G3.Fn.params.len == 1);
try expect(G3.Fn.params[0].is_generic == true);
try expect(G3.Fn.params[0].type == null);
try expect(G3.Fn.return_type == null);
const G4 = @typeInfo(@TypeOf(generic4));
try expect(G4.Fn.args.len == 1);
try expect(G4.Fn.args[0].is_generic == true);
try expect(G4.Fn.args[0].type == null);
try expect(G4.Fn.params.len == 1);
try expect(G4.Fn.params[0].is_generic == true);
try expect(G4.Fn.params[0].type == null);
try expect(G4.Fn.return_type == null);
}