motiejus/zig
1
Fork 0
Code Releases Activity

std.debug.assert: remove special case for test builds

Browse Source 
Previously, std.debug.assert would `@panic` in test builds,
if the assertion failed. Now, it's always `unreachable`.

This makes release mode test builds more accurately test
the actual code that will be run.

However this requires tests to call `std.testing.expect`
rather than `std.debug.assert` to make sure output is correct.

Here is the explanation of when to use either one, copied from
the assert doc comments:

Inside a test block, it is best to use the `std.testing` module
rather than assert, because assert may not detect a test failure
in ReleaseFast and ReleaseSafe mode. Outside of a test block, assert
is the correct function to use.

closes #1304
This commit is contained in:
Andrew Kelley
2019-02-08 18:18:47 -05:00
parent be6d022257
commit c2db077574
239 changed files with 4084 additions and 3938 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
std/math/complex/sin.zig
View File

@@ -1,5 +1,5 @@
const std = @import("../../index.zig");
const debug = std.debug;
const testing = std.testing;
const math = std.math;
const cmath = math.complex;
const Complex = cmath.Complex;
@@ -17,6 +17,6 @@ test "complex.csin" {
const a = Complex(f32).new(5, 3);
const c = sin(a);
debug.assert(math.approxEq(f32, c.re, -9.654126, epsilon));
debug.assert(math.approxEq(f32, c.im, 2.841692, epsilon));
testing.expect(math.approxEq(f32, c.re, -9.654126, epsilon));
testing.expect(math.approxEq(f32, c.im, 2.841692, epsilon));
}