motiejus/zig
1
Fork 0
Code Releases Activity

Pointer Reform: proper slicing and indexing (#1053)

Browse Source 
* enable slicing for single-item ptr to arrays
 * disable slicing for other single-item pointers
 * enable indexing for single-item ptr to arrays
 * disable indexing for other single-item pointers

see #770
closes #386
This commit is contained in:
Andrew Kelley
2018-06-04 22:11:14 -04:00
committed by GitHub
parent 32e0dfd4f0
commit e53b683bd3
21 changed files with 268 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
test/compile_errors.zig
View File

@@ -1,13 +1,22 @@
const tests = @import("tests.zig");
pub fn addCases(cases: *tests.CompileErrorContext) void {
cases.add(
"slicing single-item pointer",
\\export fn entry(ptr: *i32) void {
\\ const slice = ptr[0..2];
\\}
,
".tmp_source.zig:2:22: error: slice of single-item pointer",
);
cases.add(
"indexing single-item pointer",
\\export fn entry(ptr: *i32) i32 {
\\ return ptr[1];
\\}
,
".tmp_source.zig:2:15: error: indexing not allowed on pointer to single item",
".tmp_source.zig:2:15: error: index of single-item pointer",
);
cases.add(
@@ -144,10 +153,10 @@ pub fn addCases(cases: *tests.CompileErrorContext) void {
cases.add(
"comptime slice of undefined pointer non-zero len",
\\export fn entry() void {
\\ const slice = (*i32)(undefined)[0..1];
\\ const slice = ([*]i32)(undefined)[0..1];
\\}
,
".tmp_source.zig:2:36: error: non-zero length slice of undefined pointer",
".tmp_source.zig:2:38: error: non-zero length slice of undefined pointer",
);
cases.add(
@@ -3129,14 +3138,16 @@ pub fn addCases(cases: *tests.CompileErrorContext) void {
\\export fn entry() void {
\\ var foo = Foo { .a = 1, .b = 10 };
\\ foo.b += 1;
\\ bar((&foo.b)[0..1]);
\\ bar((*[1]u32)(&foo.b)[0..]);
\\}
\\
\\fn bar(x: []u32) void {
\\ x[0] += 1;
\\}
,
".tmp_source.zig:9:17: error: expected type '[]u32', found '[]align(1) u32'",
".tmp_source.zig:9:18: error: cast increases pointer alignment",
".tmp_source.zig:9:23: note: '*align(1) u32' has alignment 1",
".tmp_source.zig:9:18: note: '*[1]u32' has alignment 4",
);
cases.add(