From eaa6b04c3cb8073d5a1510560ec8f1e433984895 Mon Sep 17 00:00:00 2001 From: Veikka Tuominen Date: Fri, 10 Jun 2022 00:11:46 +0300 Subject: [PATCH] Sema: skip decl causing namespace lookup when doing lookup --- src/Sema.zig | 2 ++ test/behavior/basic.zig | 23 +++++++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/src/Sema.zig b/src/Sema.zig index fd127bc04a..9a34cce6e0 100644 --- a/src/Sema.zig +++ b/src/Sema.zig @@ -4967,6 +4967,8 @@ fn lookupInNamespace( var it = check_ns.usingnamespace_set.iterator(); while (it.next()) |entry| { const sub_usingnamespace_decl_index = entry.key_ptr.*; + // Skip the decl we're currently analysing. + if (sub_usingnamespace_decl_index == sema.owner_decl_index) continue; const sub_usingnamespace_decl = mod.declPtr(sub_usingnamespace_decl_index); const sub_is_pub = entry.value_ptr.*; if (!sub_is_pub and src_file != sub_usingnamespace_decl.getFileScope()) { diff --git a/test/behavior/basic.zig b/test/behavior/basic.zig index a69df862c1..ac9d90d5e6 100644 --- a/test/behavior/basic.zig +++ b/test/behavior/basic.zig @@ -1086,3 +1086,26 @@ test "inline call of function with a switch inside the return statement" { }; try expect(S.foo(1) == 1); } + +test "namespace lookup ignores decl causing the lookup" { + if (builtin.zig_backend == .stage1) return error.SkipZigTest; + if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO + if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO + if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO + if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO + + const S = struct { + fn Mixin(comptime T: type) type { + return struct { + fn foo() void { + const set = std.EnumSet(T.E).init(undefined); + _ = set; + } + }; + } + + const E = enum { a, b }; + usingnamespace Mixin(@This()); + }; + _ = S.foo(); +}