motiejus/zig
1
Fork 0
Code Releases Activity

declarations may collide with primitives with @"" syntax

Browse Source 
* stage2 AstGen: add missing compile error for declaring a local
   that shadows a primitive. Even with `@""` syntax, it may not have
   the same name as a primitive.
 * stage2 AstGen: add a compile error for a global declaration
   whose name matches a primitive. However it is allowed when using
   `@""` syntax.
 * stage1: delete all "declaration shadows primitive" compile errors
   because they are now handled by stage2 AstGen.
 * stage1/stage2 AstGen: notice when using `@""` syntax and:
   - treat `_` as a regular identifier
   - skip checking if an identifire is a primitive

Check the new test cases for clarifications on semantics.

closes #6062
This commit is contained in:
Andrew Kelley
2021-08-27 21:34:13 -07:00
parent cfae70ec8e
commit f30aa25cbf
8 changed files with 157 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
test/compile_errors.zig
View File

@@ -7258,14 +7258,41 @@ pub fn addCases(ctx: *TestContext) !void {
"tmp.zig:2:17: error: expected type 'u3', found 'u8'",
});
ctx.objErrStage1("globally shadowing a primitive type",
\\const u16 = u8;
\\export fn entry() void {
\\ const a: u16 = 300;
ctx.objErrStage1("locally shadowing a primitive type",
\\export fn foo() void {
\\ const u8 = u16;
\\ const a: u8 = 300;
\\ _ = a;
\\}
\\export fn bar() void {
\\ const @"u8" = u16;
\\ const a: @"u8" = 300;
\\ _ = a;
\\}
, &[_][]const u8{
"tmp.zig:1:1: error: declaration shadows primitive type 'u16'",
"tmp.zig:2:11: error: local shadows primitive 'u8'",
"tmp.zig:7:11: error: local shadows primitive 'u8'",
});
ctx.objErrStage1("primitives take precedence over declarations",
\\const @"u8" = u16;
\\export fn entry() void {
\\ const a: u8 = 300;
\\ _ = a;
\\}
, &[_][]const u8{
"tmp.zig:3:19: error: integer value 300 cannot be coerced to type 'u8'",
});
ctx.objErrStage1("declaration with same name as primitive must use special syntax",
\\const u8 = u16;
\\export fn entry() void {
\\ const a: u8 = 300;
\\ _ = a;
\\}
, &[_][]const u8{
"tmp.zig:1:7: error: name shadows primitive 'u8'",
"tmp.zig:1:7: note: consider using @\"u8\" to disambiguate",
});
ctx.objErrStage1("implicitly increasing pointer alignment",