motiejus/zig
1
Fork 0
Code Releases Activity

std: eliminate pointless meta.assumeSentinel() usage

Browse Source 
This fixes a bug in std.net caused during the introduction of
meta.assumeSentinel due to the unfortunate semantics of mem.span()

This leaves only 3 remaining uses of meta.assumeSentinel() in the
standard library, each of which could be a simple @ptrCast([*:0]T, foo)
instead. I think this function should likely be removed.
This commit is contained in:
Isaac Freund
2023-01-22 17:34:38 +01:00
parent c0284e242f
commit faf2fd18d3
8 changed files with 17 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/std/debug.zig
View File

@@ -978,7 +978,7 @@ pub fn readElfDebugInfo(allocator: mem.Allocator, elf_file: File) !ModuleDebugIn
for (shdrs) |*shdr| {
if (shdr.sh_type == elf.SHT_NULL) continue;
const name = std.mem.span(std.meta.assumeSentinel(header_strings[shdr.sh_name..].ptr, 0));
const name = mem.sliceTo(header_strings[shdr.sh_name..], 0);
if (mem.eql(u8, name, ".debug_info")) {
opt_debug_info = try chopSlice(mapped_mem, shdr.sh_offset, shdr.sh_size);
} else if (mem.eql(u8, name, ".debug_abbrev")) {