From fffa89700e1726508b5e5a3807fbc3a33eeea88d Mon Sep 17 00:00:00 2001 From: Jeremy Fillingim Date: Mon, 6 Dec 2021 04:10:23 +0000 Subject: [PATCH] Fix test label off-by-one error (#10277). The console test# label [test#/#tests] was being generated inside refreshWithHeldLock (in lib/std/Progress.zig), using the number of completed items. This was being incremented by 1 when displayed, which is not required. --- lib/std/Progress.zig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/std/Progress.zig b/lib/std/Progress.zig index 73a4752525..682171366b 100644 --- a/lib/std/Progress.zig +++ b/lib/std/Progress.zig @@ -266,11 +266,11 @@ fn refreshWithHeldLock(self: *Progress) void { } if (eti > 0) { if (need_ellipse) self.bufWrite(&end, " ", .{}); - self.bufWrite(&end, "[{d}/{d}] ", .{ completed_items + 1, eti }); + self.bufWrite(&end, "[{d}/{d}] ", .{ completed_items, eti }); need_ellipse = false; } else if (completed_items != 0) { if (need_ellipse) self.bufWrite(&end, " ", .{}); - self.bufWrite(&end, "[{d}] ", .{completed_items + 1}); + self.bufWrite(&end, "[{d}] ", .{completed_items}); need_ellipse = false; } }