statix: fix bugs with inherit

now I know better what it does.

flake.nix

@@ -61,7 +61,7 @@
           (_self: super: {
             deploy-rs = {
               inherit (import nixpkgs {inherit system;}) deploy-rs;
-              inherit (super.deploy-rs.lib);
+              inherit (super.deploy-rs) lib;
             };
           })
         ];

hosts/fra1-a/configuration.nix

@@ -56,7 +56,7 @@
 
       deployerbot = {
         follower = {
-          inherit (myData.hosts."vno1-oh2.servers.jakst".publicKey);
+          inherit (myData.hosts."vno1-oh2.servers.jakst") publicKey;
 
           enable = true;
           sshAllowSubnets = [myData.subnets.tailscale.sshPattern];

hosts/fwminex/configuration.nix

@@ -84,7 +84,7 @@ in {
 
       deployerbot = {
         follower = {
-          inherit (myData.hosts."vno1-oh2.servers.jakst".publicKey);
+          inherit (myData.hosts."vno1-oh2.servers.jakst") publicKey;
 
           enable = true;
           uidgid = myData.uidgid.updaterbot-deployee;

hosts/vno1-oh2/configuration.nix

@@ -196,10 +196,11 @@
         };
 
         follower = {
+          inherit (myData.hosts."vno1-oh2.servers.jakst") publicKey;
+
           enable = true;
           sshAllowSubnets = [myData.subnets.tailscale.sshPattern];
           uidgid = myData.uidgid.updaterbot-deployee;
-          inherit (myData.hosts."vno1-oh2.servers.jakst".publicKey);
         };
       };
 

hosts/vno3-rp3b/configuration.nix

@@ -94,10 +94,11 @@
 
       deployerbot = {
         follower = {
+          inherit (myData.hosts."vno1-oh2.servers.jakst") publicKey;
+
           enable = true;
           sshAllowSubnets = [myData.subnets.tailscale.sshPattern];
           uidgid = myData.uidgid.updaterbot-deployee;
-          inherit (myData.hosts."vno1-oh2.servers.jakst".publicKey);
         };
       };
 

modules/base/zfsborg/default.nix

@@ -67,8 +67,7 @@ in {
               lib.nameValuePair
               "${lib.strings.sanitizeDerivationName mountpoint}-${toString i}"
               ({
-                  inherit (attrs.repo);
-                  inherit (attrs.paths);
+                  inherit (attrs) repo paths;
 
                   doInit = true;
                   encryption = {
@@ -95,7 +94,7 @@ in {
                       BORG_RSH = ''ssh -i "${config.mj.base.zfsborg.sshKeyPath}"'';
                     };
                 }
-                // lib.optionalAttrs (attrs ? patterns) {inherit (attrs.patterns);})
+                // lib.optionalAttrs (attrs ? patterns) {inherit (attrs) patterns;})
         )
         dirs
       );

modules/services/friendlyport/default.nix

@@ -22,7 +22,7 @@
   };
 
   config = let
-    inherit (config.mj.services.friendlyport.ports);
+    inherit (config.mj.services.friendlyport) ports;
 
     mkAdd = proto: subnets: ints: let
       subnetsS = builtins.concatStringsSep "," subnets;

modules/services/jakstpub/default.nix

@@ -69,7 +69,7 @@ in {
 
     services.samba-wsdd = {
       enable = true;
-      inherit (cfg.hostname);
+      inherit (cfg) hostname;
     };
 
     users.users.jakstpub = {

modules/services/syncthing/default.nix

@@ -105,10 +105,7 @@ in {
     ];
 
     services.syncthing = {
-      inherit (cfg.enable);
-      inherit (cfg.user);
-      inherit (cfg.group);
-      inherit (cfg.dataDir);
+      inherit (cfg) enable user group dataDir;
 
       openDefaultPorts = true;
       guiAddress = let

statix.toml

@@ -0,0 +1 @@
+ignore = ['modules/base/boot']