motiejus/hermetic_cc_toolchain
1
Fork 0
Code Releases Activity

ci/lint: make it fail in CI

Browse Source 
It would "fix" the files on CI and not fail. ci/lint should verify they
are OK first, and give guidance to fix them.

also, `shellcheck -x` is no longer necessary; we can use the plain one
now.
This commit is contained in:
Motiejus Jakštys 2022-09-29 12:11:34 +03:00
parent b9ded4caeb
commit ae57dac00d
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ci/lint
View File

@ -12,10 +12,19 @@ mapfile -t buildfiles < \
>&2 echo "shellcheck" >&2 echo "shellcheck"
for f in "${scripts[@]}"; do >&2 echo " $f"; done for f in "${scripts[@]}"; do >&2 echo " $f"; done
shellcheck -x "${scripts[@]}" shellcheck "${scripts[@]}"
>&2 echo -e "OK\n" >&2 echo -e "OK\n"
>&2 echo "buildifier" >&2 echo "buildifier -mode diff"
for f in "${buildfiles[@]}"; do >&2 echo " $f"; done for f in "${buildfiles[@]}"; do >&2 echo " $f"; done
buildifier "${buildfiles[@]}" fail=0
out=$(buildifier -mode diff -diff_command='diff -u' "${buildfiles[@]}") || fail=1
if [[ "$fail" == 1 ]]; then
>&2 echo "ERROR: buildifier:"
echo "$out"
>&2 echo
>&2 echo "You may try running:"
>&2 echo " buildifier ${buildfiles[*]}"
exit 1
fi
>&2 echo -e "OK\n" >&2 echo -e "OK\n"