motiejus
/
jgit
1
Fork 0
Code Releases Activity

ArchiveTest: Don't use string concatenation in loop 

According to FindBugs:

  In each iteration, the String is converted to a StringBuffer/
  StringBuilder, appended to, and converted back to a String. This
  can lead to a cost quadratic in the number of iterations, as the
  growing string is recopied in each iteration.

Replace string concatenation with StringBuffer.

Change-Id: I60e09f274bed6722f4e0e4d096b0f2b1b31ec1b4
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
This commit is contained in:
David Pursehouse 2016-10-19 12:54:46 +09:00
parent 9ed2d949bb
commit 8f9e157cd5
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
org.eclipse.jgit.pgm.test/tst/org/eclipse/jgit/pgm/ArchiveTest.java
View File

@ -528,15 +528,15 @@ public void testTarPreservesMode() throws Exception {
@Test
public void testArchiveWithLongFilename() throws Exception {
String filename = "";
StringBuilder filename = new StringBuilder();
List<String> l = new ArrayList<String>();
for (int i = 0; i < 20; i++) {
filename = filename + "1234567890/";
l.add(filename);
filename.append("1234567890/");
l.add(filename.toString());
}
filename = filename + "1234567890";
l.add(filename);
writeTrashFile(filename, "file with long path");
filename.append("1234567890");
l.add(filename.toString());
writeTrashFile(filename.toString(), "file with long path");
git.add().addFilepattern("1234567890").call();
git.commit().setMessage("file with long name").call();
@ -548,15 +548,15 @@ public void testArchiveWithLongFilename() throws Exception {
@Test
public void testTarWithLongFilename() throws Exception {
String filename = "";
StringBuilder filename = new StringBuilder();
List<String> l = new ArrayList<String>();
for (int i = 0; i < 20; i++) {
filename = filename + "1234567890/";
l.add(filename);
filename.append("1234567890/");
l.add(filename.toString());
}
filename = filename + "1234567890";
l.add(filename);
writeTrashFile(filename, "file with long path");
filename.append("1234567890");
l.add(filename.toString());
writeTrashFile(filename.toString(), "file with long path");
git.add().addFilepattern("1234567890").call();
git.commit().setMessage("file with long name").call();