motiejus
/
jgit
1
Fork 0
Code Releases Activity

[errorprone] MyersDiff#main: fix CatchAndPrintStackTrace 

Use a PrintWriter similarly like Main#run of org.eclipse.jgit.pgm does.

See https://errorprone.info/bugpattern/CatchAndPrintStackTrace

Change-Id: I8ee34da53d94ddb72b73ae86bfebc3b7f0a3dc04
This commit is contained in:
Matthias Sohn 2023-09-21 12:22:24 +02:00
parent 2d16df1a07
commit e6c808600d
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
org.eclipse.jgit/src/org/eclipse/jgit/diff/MyersDiff.java
View File

@ -11,6 +11,10 @@
package org.eclipse.jgit.diff;
import static java.nio.charset.StandardCharsets.UTF_8;
import java.io.OutputStreamWriter;
import java.io.PrintWriter;
import java.text.MessageFormat;
import org.eclipse.jgit.errors.DiffInterruptedException;
@ -531,7 +535,7 @@ final boolean meets(int d, int k, int x, long snake) {
*/
public static void main(String[] args) {
if (args.length != 2) {
System.err.println(JGitText.get().need2Arguments);
err().println(JGitText.get().need2Arguments);
System.exit(1);
}
try {
@ -540,7 +544,13 @@ public static void main(String[] args) {
EditList r = INSTANCE.diff(RawTextComparator.DEFAULT, a, b);
System.out.println(r.toString());
} catch (Exception e) {
e.printStackTrace();
PrintWriter err = err();
err.println(e.getMessage());
e.printStackTrace(err);
}
}
private static PrintWriter err() {
return new PrintWriter(new OutputStreamWriter(System.err, UTF_8));
}
}