Commit Graph

3659 Commits

Author SHA1 Message Date
Matthias Sohn 5362e1d41c Delete deprecated checkoutEntry() methods in DirCacheCheckout
Change-Id: I7fcf6534e6092ba87360ccd68a7dd7466c5c8911
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-25 00:22:59 +02:00
Shawn Pearce 6e5c71b358 Remove validate support when reusing cached pack
Cached packs are only used when writing over the network or to
a bundle file and reuse validation is always disabled in these
two contexts. The client/consumer of the stream will be SHA-1
checksumming every object.

Reuse validation is most critical during local GC to avoid silently
ignoring corruption by stopping as soon as a problem is found and
leaving everything alone for the end-user to debug and salvage.
Cached packs are not supported during local GC as the bitmap rebuild
logic does not support including a cached pack in the result.

Strip out the validation and force PackWriter to always disable the
cached pack feature if reuseValidation is enabled.

Change-Id: If0d7baf2ae1bf1f7e71bf773151302c9f7887039
2015-04-24 11:31:22 -07:00
Shawn Pearce a3476ced1f Rename copyThroughCache to shouldCopyThroughCache
Sensible suggestion from Terry Parker as a late comment on
commit f2efcdc6f769d59722b17e9274932d585035cfb6.

Change-Id: I225775bfb6d3d91ae066ff00f9d80a9c02a422c2
2015-04-24 11:07:22 -07:00
Shawn Pearce 1553a6ff55 Add readAheadBuffer hint to ReadableChannel
This hint allows an underlying implementation to read more bytes when
possible and buffer them locally for future read calls to consume.

Change-Id: Ia986a1bb8640eecb91cfbd515c61fa1ff1574a6f
2015-04-24 11:06:56 -07:00
Shawn Pearce 3fa520b653 Merge "Restore AwtCredentialsProvider to enable debugging pgm in Eclipse" 2015-04-24 12:47:48 -04:00
Shawn Pearce c761c8bb5c Avoid storing large packs in block cache during reuse
When a large pack (> 30% of the block cache) is being reused by
copying it pollutes the block cache with noise by storing blocks
that are never referenced again.

Avoid this by streaming the file directly from its channel onto
the output stream.

Change-Id: I2e53de27f3dcfb93de68b1fad45f75ab23e79fe7
2015-04-23 20:22:13 -07:00
Matthias Sohn ff798f13da Restore AwtCredentialsProvider to enable debugging pgm in Eclipse
In 6c1f739388 the AWT based credentials
provider was dropped because we don't support Java 5 any longer so we
can always use the ConsoleCredentialsProvider which requires Java 6.
This broke debugging org.eclipse.jgit.pgm since Eclipse doesn't support
using a system console authenticator [1].

[1] see https://bugs.eclipse.org/bugs/show_bug.cgi?id=148831

Change-Id: Iba71001a7762e73d6579ba9dfa5a08ddaba777ea
2015-04-22 12:53:35 +02:00
David Pletcher 12e38d7275 Expose public getDepth method
The clone or fetch depth is a valuable bit of information
for access logging. Create a public getter to faciliate access.
A precondition check prevents unintentional misuse when the
data isn't valid yet.

Change-Id: I4603d5fd3bd4a767e3e2419b0f2da3664cfbd7f8
Signed-off-by: David Pletcher <dpletcher@google.com>
2015-04-16 15:50:43 -07:00
Matthias Sohn 41c4f9cb2a Fix error message to include cause if ResetCommand fails
Bug: 464048
Change-Id: I6e7d9262b94cb168c84faef1dea22c1e082fe5ad
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-16 14:28:39 +02:00
Shawn Pearce 300a55dcba Merge "FS.readPipe() shouldn't log IOException as an error" 2015-04-08 21:08:51 -04:00
Shawn Pearce 9fb6d217b5 Merge "Remove obsolete API warning filters to silence warnings" 2015-04-08 21:08:31 -04:00
Shawn Pearce e0d95ab577 Merge "Use try-with-resources to fix warnings in AddCommand" 2015-04-08 21:08:01 -04:00
Shawn Pearce 481405f770 Merge changes Iad4d4127,I0211bcf0
* changes:
  Silence warning for non-translatable String in AddNoteCommand
  Use try-with-resources to fix warnings in AddNoteCommand
2015-04-08 21:07:06 -04:00
Shawn Pearce a0bc9560aa Merge changes I28a5c7e2,If90a6cca
* changes:
  Replace use of deprecated release() in BasePackPushConnection
  Replace use of deprecated release() in BasePackFetchConnection
2015-04-08 21:05:33 -04:00
Shawn Pearce 5ef9c1709e Merge changes I184945ee,Iacaad1a7
* changes:
  Remove unnecessary $NON-NLS comment in BaseReceivePack
  Use try-with-resources to close resources in BaseReceivePack
2015-04-08 21:04:08 -04:00
Shawn Pearce 9b9087d47d Merge changes Ic555e6e0,Id4cb9a23
* changes:
  Replace use of deprecated release() method in BlameResult
  Use try-with-resource to close BlameGenerator
2015-04-08 20:59:05 -04:00
Shawn Pearce f96e15b1e6 Merge "Use try-with-resource to close resources in BlobBasedConfig" 2015-04-08 20:58:32 -04:00
Shawn Pearce 32cc3c3096 Merge "Use try-with-resource to close resources in BundleFetchConnection" 2015-04-08 20:57:53 -04:00
Shawn Pearce 7810d9bc42 Merge "Use try-with-resource to close resources in BundleWriter" 2015-04-08 20:56:24 -04:00
Matthias Sohn d726f0c1e0 Use try-with-resource to close resources in CommitCommand
Change-Id: Ibbbc74acfd050f28e68f318970660b5959caf7e3
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-08 22:53:20 +02:00
Matthias Sohn bb2ca576ff Externalize error message used in CheckoutCommand
Change-Id: Ifbc469b07e63218107157ffbf23ae55c52a55ef4
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-08 22:52:06 +02:00
Matthias Sohn 7343c7a10f Use try-with-resource to close resources in CheckoutCommand
Change-Id: Ia4d4f9bff03a03d116b80022d7691df67bf8b51b
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-08 22:52:05 +02:00
Shawn Pearce f4ded63880 Merge "Fix resource leak in ChangeIdUtil" 2015-04-08 16:08:43 -04:00
Shawn Pearce 2b2cd4ba53 Merge changes I11631afb,Iaa51a46a
* changes:
  Externalize error messages used in DfsGarbageCollector
  Use try-with-resource to close resources in DfsGarbageCollector
2015-04-08 15:53:48 -04:00
Shawn Pearce 297600f7c2 Merge changes I8c06635c,I62d6de7d
* changes:
  Silence non-externalized string warning in CherryPickCommand
  Use try-with-resource to close resources in CherryPickCommand
2015-04-08 15:30:50 -04:00
Shawn Pearce ba8b275ac5 Merge "Silence non-externalized string warnings in CherryPickResult" 2015-04-08 15:30:17 -04:00
Shawn Pearce b2bba1419f Merge "Use try-with-resource to close resources in CloneCommand" 2015-04-08 15:29:53 -04:00
Shawn Pearce 881dfc0147 Merge "Replace call to deprecated RevWalk.release() in DescribeCommand" 2015-04-08 15:26:21 -04:00
Shawn Pearce 15a95e3911 Merge "Use try-with-resource to close resources in DiffCommand" 2015-04-08 15:26:07 -04:00
Shawn Pearce e0477d3fe0 Merge "Fix resource leak in DiffFormatter" 2015-04-08 15:25:30 -04:00
Shawn Pearce f3a44db491 Merge "Use try-with-resource to close resources in DirCache" 2015-04-08 15:22:58 -04:00
Matthias Sohn 842ae868cf Externalize error messages used in DfsGarbageCollector
Change-Id: I11631afb33a2bb29d994551a0be8775bbe277300
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-08 12:22:31 -07:00
Matthias Sohn 13cfc83b2b Use try-with-resource to close resources in DfsGarbageCollector
Change-Id: Iaa51a46a9dde13d6f5c0f9ff54a68cea0ef1fde3
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-08 12:22:31 -07:00
Shawn Pearce 429e96eab6 Merge "Reduce visibility of DirCacheCheckout.checkValidPath()" 2015-04-08 15:21:17 -04:00
Shawn Pearce ad1aa922de Merge "Use try-with-resource to close resources in FetchProcess" 2015-04-08 15:20:37 -04:00
Shawn Pearce a80adfbf9c Merge "Use try-with-resource to close resources in GC" 2015-04-08 15:20:15 -04:00
Shawn Pearce 66a95621a3 Merge "Replace deprecated release() methods by close() in Merger" 2015-04-08 15:19:19 -04:00
Shawn Pearce 6e1dc98672 Merge "Ensure that NameRevCommand.call() closes RevWalk" 2015-04-08 15:18:13 -04:00
Shawn Pearce 754b855f73 Merge "Replace deprecated release() methods by close() in NoteMapMerger" 2015-04-08 15:17:29 -04:00
Shawn Pearce 67568ee630 Merge "Use try-with-resource to close resources in ObjectDatabase" 2015-04-08 15:17:13 -04:00
Shawn Pearce aa94e3f3ae Merge changes Ia3908555,I3bc26847
* changes:
  Silence false null pointer access warnings in PackFile
  Externalize error messages used in ObjectDirectoryInserter
2015-04-08 15:16:53 -04:00
Shawn Pearce 96a5ec43fa Merge "Silence non-externalized string warning in PackIndexV2" 2015-04-08 15:15:47 -04:00
Shawn Pearce 9bea73693e Merge changes I1a4181fc,Ic2db0511
* changes:
  Silence non-externalized string warning in PackParser
  Replace call to deprecated release() by close() in PackParser
2015-04-08 15:15:33 -04:00
Matthias Sohn 8d41c783c0 Silence non-externalized string warning in PackParser
Change-Id: I1a4181fc292c42157c69479f71c7674b2e00d2ce
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-04 00:54:24 +02:00
Matthias Sohn e5a6290ac9 Replace call to deprecated release() by close() in PackParser
Change-Id: Ic2db051130059cce89486f55ecca32a7ce6715fd
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-04 00:53:47 +02:00
Matthias Sohn 6feb7bc9dd Silence non-externalized string warning in PackIndexV2
Change-Id: I8c94811972c593c898f6375178f250a2123d01c6
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-04 00:51:05 +02:00
Matthias Sohn 4dd4d7e12a Silence false null pointer access warnings in PackFile
Change-Id: Ia39085557b38840dfaa9b4995e6f6c40e19042cb
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-04 00:49:05 +02:00
Matthias Sohn fc2d723dd9 Externalize error messages used in ObjectDirectoryInserter
Change-Id: I3bc26847071fbc31267a4a4cf5a10b428bcf229d
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-04 00:45:33 +02:00
Matthias Sohn 1728d1d760 Use try-with-resource to close resources in ObjectDatabase
Change-Id: Ib410bf0d3c300c25b615bb6a51488b3d88aeb3bd
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-04 00:38:39 +02:00
Matthias Sohn f777ed1d24 Replace deprecated release() methods by close() in NoteMapMerger
Change-Id: Iaa76f0e853bb82cd7f231fd2f462a319f4196d8c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-04-04 00:36:28 +02:00