motiejus/zig
1
Fork 0
Code Releases Activity

macho: disable splitting sections into atoms in release

Browse Source 
since we don't actually benefit from it just yet, and getting
it right for release and dead code stripping will require some more
thought put into it.
This commit is contained in:
Jakub Konka
2021-09-14 10:28:58 +02:00
parent a38b636045
commit 05763f43b3
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/link/MachO/Object.zig
View File

@@ -540,12 +540,15 @@ pub fn parseIntoAtoms(
// Symbols within this section only.
const filtered_nlists = NlistWithIndex.filterInSection(sorted_nlists, sect);
// TODO rewrite and re-enable dead-code stripping optimisation. I think it might make sense
// to do this in a standalone pass after we parse the sections as atoms.
// In release mode, if the object file was generated with dead code stripping optimisations,
// note it now and parse sections as atoms.
const is_splittable = blk: {
if (macho_file.base.options.optimize_mode == .Debug) break :blk false;
break :blk self.header.?.flags & macho.MH_SUBSECTIONS_VIA_SYMBOLS != 0;
};
// const is_splittable = blk: {
// if (macho_file.base.options.optimize_mode == .Debug) break :blk false;
// break :blk self.header.?.flags & macho.MH_SUBSECTIONS_VIA_SYMBOLS != 0;
// };
const is_splittable = false;
macho_file.has_dices = macho_file.has_dices or blk: {
if (self.text_section_index) |index| {