zig

commit 15cf1315bb945f2a14a48e2cc7ee2eaf2e0536d2 (tree)
parent 0a3e566f57063c42146aa2d64481a7eb1361f96f
Author: Robin Voetter <robin@voetter.nl>
Date:   Sun,  8 Oct 2023 00:06:06 +0200

spirv: fix incorrect repr of some optional operations

Diffstat:
M
src/codegen/spirv.zig
 | 
12
++++++++----
M
test/behavior/cast.zig
 | 
1
-
M
test/behavior/for.zig
 | 
1
-

3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/codegen/spirv.zig b/src/codegen/spirv.zig
@@ -3594,11 +3594,13 @@ const DeclGen = struct {
             return result_id;
         }
 
-        const is_non_null_id = if (optional_ty.hasRuntimeBitsIgnoreComptime(mod))
+        const is_non_null_id = if (payload_ty.hasRuntimeBitsIgnoreComptime(mod))
             try self.extractField(Type.bool, operand_id, 1)
         else
             // Optional representation is bool indicating whether the optional is set
-            operand_id;
+            // Optionals with no payload are represented as an (indirect) bool, so convert
+            // it back to the direct bool here.
+            try self.convertToDirect(Type.bool, operand_id);
 
         return switch (pred) {
             .is_null => blk: {
@@ -3677,17 +3679,19 @@ const DeclGen = struct {
         const payload_ty = self.typeOf(ty_op.operand);
 
         if (!payload_ty.hasRuntimeBitsIgnoreComptime(mod)) {
-            return try self.constBool(true, .direct);
+            return try self.constBool(true, .indirect);
         }
 
         const operand_id = try self.resolve(ty_op.operand);
+
         const optional_ty = self.typeOfIndex(inst);
         if (optional_ty.optionalReprIsPayload(mod)) {
             return operand_id;
         }
 
         const optional_ty_ref = try self.resolveType(optional_ty, .direct);
-        const members = [_]IdRef{ operand_id, try self.constBool(true, .indirect) };
+        const payload_id = try self.convertToIndirect(payload_ty, operand_id);
+        const members = [_]IdRef{ payload_id, try self.constBool(true, .indirect) };
         return try self.constructStruct(optional_ty_ref, &members);
     }
 
diff --git a/test/behavior/cast.zig b/test/behavior/cast.zig
@@ -240,7 +240,6 @@ test "coerce undefined to optional" {
     if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
     if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
     if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
-    if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest;
 
     try expect(MakeType(void).getNull() == null);
     try expect(MakeType(void).getNonNull() != null);
diff --git a/test/behavior/for.zig b/test/behavior/for.zig
@@ -492,7 +492,6 @@ test "inferred alloc ptr of for loop" {
     if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
     if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
     if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
-    if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest; // TODO
 
     {
         var cond = false;