zig

commit 1a2e02e267216bb35937d25598c773255d830b25 (tree)
parent 3bc361178c0f37ee9ffb67698401027a9f656664
Author: Jimmi HC <jimmiholstchristensen@gmail.com>
Date:   Wed, 24 Apr 2019 15:04:58 +0200

fixed #2356

const_ptr_pointee_unchecked did not take into account that if the
pointer is zero sized, then const_val->data.x_ptr.special would be
ConstPtrSpecialInvalid. This commit fixes this by also checking
that the child type of the pointer only have one possible value
and just returns that value.

Diffstat:
M
src/ir.cpp
 | 
13
+++++++++++++
M
test/stage1/behavior.zig
 | 
1
+
A
test/stage1/behavior/bugs/2346.zig
 | 
7
+++++++

3 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/src/ir.cpp b/src/ir.cpp
@@ -188,6 +188,19 @@ static ConstExprValue *const_ptr_pointee_unchecked(CodeGen *g, ConstExprValue *c
     assert(get_src_ptr_type(const_val->type) != nullptr);
     assert(const_val->special == ConstValSpecialStatic);
     ConstExprValue *result;
+    
+    switch (type_has_one_possible_value(g, const_val->type->data.pointer.child_type)) {
+        case OnePossibleValueInvalid:
+            zig_unreachable();
+        case OnePossibleValueYes:
+            result = create_const_vals(1);
+            result->type = const_val->type->data.pointer.child_type;
+            result->special = ConstValSpecialStatic;
+            return result;
+        case OnePossibleValueNo:
+            break;
+    }
+    
     switch (const_val->data.x_ptr.special) {
         case ConstPtrSpecialInvalid:
             zig_unreachable();
diff --git a/test/stage1/behavior.zig b/test/stage1/behavior.zig
@@ -24,6 +24,7 @@ comptime {
     _ = @import("behavior/bugs/1851.zig");
     _ = @import("behavior/bugs/1914.zig");
     _ = @import("behavior/bugs/2006.zig");
+    _ = @import("behavior/bugs/2346.zig");
     _ = @import("behavior/bugs/394.zig");
     _ = @import("behavior/bugs/421.zig");
     _ = @import("behavior/bugs/529.zig");
diff --git a/test/stage1/behavior/bugs/2346.zig b/test/stage1/behavior/bugs/2346.zig
@@ -0,0 +1,6 @@
+test "" {
+    const a: *void = undefined;
+    const b: *[1]void = a;
+    const c: *[0]u8 = undefined;
+    const d: []u8 = c;
+}
+\ No newline at end of file