zig

commit 2f96c55095514de35a25ec2cf84a79e6c5e3a646 (tree)
parent 0cccba71d41afee519d0000eb719f8c95f288166
Author: Andrew Kelley <andrew@ziglang.org>
Date:   Tue,  2 Apr 2019 15:29:16 -0400

fix cache hash regression

fixes "warning: unexpected seek failure"

fix regression introduced by 27e31f04758d95cb7cf51a74e2a3903553ce3bc5

the fd should be closed only if returning with an error

Diffstat:
M
src/cache_hash.cpp
 | 
4
+++-

1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/cache_hash.cpp b/src/cache_hash.cpp
@@ -437,7 +437,9 @@ Error cache_hit(CacheHash *ch, Buf *out_digest) {
                 return ErrorCacheUnavailable;
             }
         }
-        os_file_close(ch->manifest_file);
+        if (return_code != ErrorNone) {
+            os_file_close(ch->manifest_file);
+        }
         return return_code;
     }
     // Cache Hit