motiejus/zig
1
Fork 0
Code Releases Activity

std.math.lossyCast: fix integer overflow

Browse Source 
Fixes integer overflow caused by cast from maxInt(u32) as an f32 to u32.
This commit is contained in:
ominitay
2022-03-10 19:53:28 +00:00
committed by Veikka Tuominen
parent b3259b47ad
commit 42d75f1a25
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/std/math.zig
View File

@@ -1190,18 +1190,18 @@ pub fn lossyCast(comptime T: type, value: anytype) T {
.Int => {
switch (@typeInfo(@TypeOf(value))) {
.Int, .ComptimeInt => {
if (value > maxInt(T)) {
if (value >= maxInt(T)) {
return @as(T, maxInt(T));
} else if (value < minInt(T)) {
} else if (value <= minInt(T)) {
return @as(T, minInt(T));
} else {
return @intCast(T, value);
}
},
.Float, .ComptimeFloat => {
if (value > maxInt(T)) {
if (value >= maxInt(T)) {
return @as(T, maxInt(T));
} else if (value < minInt(T)) {
} else if (value <= minInt(T)) {
return @as(T, minInt(T));
} else {
return @floatToInt(T, value);
@@ -1218,6 +1218,7 @@ test "lossyCast" {
try testing.expect(lossyCast(i16, 70000.0) == @as(i16, 32767));
try testing.expect(lossyCast(u32, @as(i16, -255)) == @as(u32, 0));
try testing.expect(lossyCast(i9, @as(u32, 200)) == @as(i9, 200));
try testing.expect(lossyCast(u32, @as(f32, maxInt(u32))) == maxInt(u32));
}
test "f64_min" {