zig

commit 490a411fd4e00fee65bc014fa7b1af59042d269b (tree)
parent ccf670c2b04ebeb9db43eb9f5c47c6cf03e4b1d0
Author: Michael Dusan <michael.dusan@gmail.com>
Date:   Mon, 10 Apr 2023 19:06:39 -0400

openbsd: fix thread name buffer size

OpenBSD 7.3 changed its implementation of
pthread_get_name_np/pthread_set_name_np to wrap new libc functions
getthrname/setthrname and lowered the max buffer size from 32 to 24.

This is not a backwards-compatible change because if we were to put in
comptime version logic to use size 32 when target < 7.3 the binaries
would be undefined when running on >= 7.3. It also could simply be that
OpenBSD has a policy to not support older binaries running on newer
releases? Regardless, the safest course is to simply use the smallest
known buffer size.

As an aside, this bug manifested as a "hung" std.Thread test because 7.3
pthread API never checks for error result when wrapping getthrname/setthrname.
This is not a problem in std.Thread when we use the correct max buffer
size because ERANGE/EINVAL become unreachable.

Diffstat:
M
lib/std/Thread.zig
 | 
2
+-

1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/std/Thread.zig b/lib/std/Thread.zig
@@ -40,7 +40,7 @@ pub const max_name_len = switch (target.os.tag) {
     .macos, .ios, .watchos, .tvos => 63,
     .netbsd => 31,
     .freebsd => 15,
-    .openbsd => 31,
+    .openbsd => 23,
     .dragonfly => 1023,
     .solaris => 31,
     else => 0,