zig

commit 4ea2f441df36cec61e1017f4d795d4037326c98c (tree)
parent 3169f0529b22fca2a387a841a62fec29b3d2096a
Author: Andrius Bentkus <andrius.bentkus@gmail.com>
Date:   Sat, 16 Jul 2022 15:46:13 +0300

Module: retry ZIR cache file creation

There are no dir components, so you would think that this was
unreachable, however we have observed on macOS two processes racing to
do openat() with O_CREAT manifest in ENOENT.

closes #12138

Diffstat:
M
src/Module.zig
 | 
33
+++++++++++++++++++--------------

1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/src/Module.zig b/src/Module.zig
@@ -3569,20 +3569,25 @@ pub fn astGenFile(mod: *Module, file: *File) !void {
     // If another process is already working on this file, we will get the cached
     // version. Likewise if we're working on AstGen and another process asks for
     // the cached file, they'll get it.
-    const cache_file = zir_dir.createFile(&digest, .{
-        .read = true,
-        .truncate = false,
-        .lock = lock,
-    }) catch |err| switch (err) {
-        error.NotDir => unreachable, // no dir components
-        error.InvalidUtf8 => unreachable, // it's a hex encoded name
-        error.BadPathName => unreachable, // it's a hex encoded name
-        error.NameTooLong => unreachable, // it's a fixed size name
-        error.PipeBusy => unreachable, // it's not a pipe
-        error.WouldBlock => unreachable, // not asking for non-blocking I/O
-        error.FileNotFound => unreachable, // no dir components
-
-        else => |e| return e, // Retryable errors are handled at callsite.
+    const cache_file = while (true) {
+        break zir_dir.createFile(&digest, .{
+            .read = true,
+            .truncate = false,
+            .lock = lock,
+        }) catch |err| switch (err) {
+            error.NotDir => unreachable, // no dir components
+            error.InvalidUtf8 => unreachable, // it's a hex encoded name
+            error.BadPathName => unreachable, // it's a hex encoded name
+            error.NameTooLong => unreachable, // it's a fixed size name
+            error.PipeBusy => unreachable, // it's not a pipe
+            error.WouldBlock => unreachable, // not asking for non-blocking I/O
+            // There are no dir components, so you would think that this was
+            // unreachable, however we have observed on macOS two processes racing
+            // to do openat() with O_CREAT manifest in ENOENT.
+            error.FileNotFound => continue,
+
+            else => |e| return e, // Retryable errors are handled at callsite.
+        };
     };
     defer cache_file.close();