zig

commit 8f224bc3f0065aaf971126de65b5d56d2d6d522d (tree)
parent 0d95b44a1c9e483beb82f7b70515185159d79bdc
Author: Andrew Kelley <andrew@ziglang.org>
Date:   Thu, 30 Apr 2026 11:46:56 -0700

rename addBuildPositionals to addCliExtras

they don't have to be positionals

Diffstat:
M
BRANCH_TODO
 | 
2
+-
M
lib/compiler/Maker/Step/Run.zig
 | 
4
++--
M
lib/compiler/configurer.zig
 | 
4
++--
M
lib/init/build.zig
 | 
2
+-
M
lib/std/Build/Configuration.zig
 | 
2
+-
M
lib/std/Build/Step/Run.zig
 | 
6
+++---

6 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/BRANCH_TODO b/BRANCH_TODO
@@ -40,5 +40,5 @@ if (b.args) |args| {
 ⬇️
 
 ```zig
-run_cmd.addBuildPositionals();
+run_cmd.addCliExtras();
 ```
diff --git a/lib/compiler/Maker/Step/Run.zig b/lib/compiler/Maker/Step/Run.zig
@@ -177,7 +177,7 @@ pub fn make(
                 });
                 argv_list.items.len += 1;
             },
-            .cli_positionals => {
+            .cli_extras => {
                 any_cli_positionals = true;
                 if (maker.run_args) |run_args| {
                     try argv_list.appendSlice(gpa, run_args);
@@ -1599,7 +1599,7 @@ pub fn rerunInFuzzMode(
             },
             .output_file => unreachable,
             .output_directory => unreachable,
-            .cli_positionals => unreachable,
+            .cli_extras => unreachable,
         }
     }
 
diff --git a/lib/compiler/configurer.zig b/lib/compiler/configurer.zig
@@ -492,9 +492,9 @@ const Serialize = struct {
                     .producer = .{ .value = null },
                     .generated = .{ .value = a.generated_file },
                 },
-                .cli_positionals => .{
+                .cli_extras => .{
                     .flags = .{
-                        .tag = .cli_positionals,
+                        .tag = .cli_extras,
                         .prefix = false,
                         .suffix = false,
                         .basename = false,
diff --git a/lib/init/build.zig b/lib/init/build.zig
@@ -111,7 +111,7 @@ pub fn build(b: *std.Build) void {
 
     // This allows the user to pass arguments to the application in the build
     // command itself, like this: `zig build run -- arg1 arg2 etc`
-    run_cmd.addCliPositionals();
+    run_cmd.addCliExtras();
 
     // Creates an executable that will run `test` blocks from the provided module.
     // Here `mod` needs to define a target, which is why earlier we made sure to
diff --git a/lib/std/Build/Configuration.zig b/lib/std/Build/Configuration.zig
@@ -567,7 +567,7 @@ pub const Step = extern struct {
                 file_content,
                 output_file,
                 output_directory,
-                cli_positionals,
+                cli_extras,
             };
 
             pub const Index = IndexType(@This());
diff --git a/lib/std/Build/Step/Run.zig b/lib/std/Build/Step/Run.zig
@@ -142,7 +142,7 @@ pub const Arg = union(enum) {
     output_file_dep: *Output,
     output_directory: *Output,
     /// The arguments passed after "--" on the "zig build" CLI.
-    cli_positionals,
+    cli_extras,
 };
 
 pub const PrefixedArtifact = struct {
@@ -523,10 +523,10 @@ pub fn addArgs(run: *Run, args: []const []const u8) void {
 ///
 /// In the example command `zig build run -- arg1 arg2`, "arg1" and "arg2" will
 /// be passed to the process being run.
-pub fn addCliPositionals(run: *Run) void {
+pub fn addCliExtras(run: *Run) void {
     const graph = run.step.owner.graph;
     const arena = graph.arena;
-    run.argv.append(arena, .cli_positionals) catch @panic("OOM");
+    run.argv.append(arena, .cli_extras) catch @panic("OOM");
 }
 
 pub fn setStdIn(run: *Run, stdin: StdIn) void {