zig

commit 9b292c094909e51718c1d37dbeb859674dd98c8a (tree)
parent 93c546c8c9bf20b70b49546f278b4663b5c3f6d7
Author: Will Lillis <wlillis@umass.edu>
Date:   Sun, 21 Jul 2024 03:03:23 -0400

fix: Add error notes for method calls on double pointers (#20686)


Diffstat:
M
src/Sema.zig
 | 
4
++++
A
test/cases/compile_errors/call_from_double_ptr.zig
 | 
15
+++++++++++++++

2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/src/Sema.zig b/src/Sema.zig
@@ -28023,6 +28023,10 @@ fn fieldCallBind(
         if (concrete_ty.zigTypeTag(mod) == .ErrorUnion) {
             try sema.errNote(src, msg, "consider using 'try', 'catch', or 'if'", .{});
         }
+        if (is_double_ptr) {
+            try sema.errNote(src, msg, "method invocation only supports up to one level of implicit pointer dereferencing", .{});
+            try sema.errNote(src, msg, "use '.*' to dereference pointer", .{});
+        }
         break :msg msg;
     };
     return sema.failWithOwnedErrorMsg(block, msg);
diff --git a/test/cases/compile_errors/call_from_double_ptr.zig b/test/cases/compile_errors/call_from_double_ptr.zig
@@ -0,0 +1,15 @@
+const S = struct {
+    fn b() void {}
+};
+
+export fn entry(a: **S) void {
+    _ = a.b();
+}
+
+// error
+// backend=stage2
+// target=native
+//
+// 6:10: error: no field or member function named 'b' in '*tmp.S'
+// 6:10: note: method invocation only supports up to one level of implicit pointer dereferencing
+// 6:10: note: use '.*' to dereference pointer