zig

commit ac9f020c878c6397cee0f476b0afd5ce38178374 (tree)
parent b0c17a6becae820624da8cf41c880184ce0a104e
Author: Andrew Kelley <andrew@ziglang.org>
Date:   Thu,  4 Jun 2026 00:02:36 -0700

StaticStringMap: failing unit test

getIndex doesn't return an index based on the input, it returns an
internal index to the generated sorted array

this makes it unfit to be public

Diffstat:
M
lib/std/static_string_map.zig
 | 
14
+++++++-------

1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/std/static_string_map.zig b/lib/std/static_string_map.zig
@@ -240,7 +240,7 @@ pub fn StaticStringMapWithEql(
             return self.kvs.values[self.getIndex(str) orelse return null];
         }
 
-        pub fn getIndex(self: Self, str: []const u8) ?usize {
+        fn getIndex(self: Self, str: []const u8) ?usize {
             const kvs = self.kvs.*;
             if (kvs.len == 0)
                 return null;
@@ -583,13 +583,13 @@ test "sorting kvs doesn't exceed eval branch quota" {
 }
 
 test "initEnum" {
-    const map = StaticStringMap(void).initEnum(TestEnum);
+    const UnsortedEnum = enum { BB, A, CCC, DDD };
+    const map = StaticStringMap(void).initEnum(UnsortedEnum);
     try testing.expect(map.has("A"));
     try testing.expect(!map.has("a"));
-    try testing.expectEqual(0, map.getIndex("A"));
-    try testing.expectEqual(1, map.getIndex("B"));
-    try testing.expectEqual(2, map.getIndex("C"));
-    try testing.expectEqual(3, map.getIndex("D"));
-    try testing.expectEqual(4, map.getIndex("E"));
+    try testing.expectEqual(0, map.getIndex("BB"));
+    try testing.expectEqual(1, map.getIndex("A"));
+    try testing.expectEqual(2, map.getIndex("CCC"));
+    try testing.expectEqual(3, map.getIndex("DDD"));
     try testing.expectEqual(null, map.getIndex("F"));
 }