zig

commit b3af5d076c24744bdd100c25eabfea2a1a4688cf (tree)
parent da0509750a332806cfddad24b88ae8900782185d
Author: Evin Yulo <yujiri@disroot.org>
Date:   Wed, 15 Mar 2023 12:53:53 -0400

Fix #14901: parseFloat parsing `0x` successfully

Diffstat:
M
lib/std/fmt/parse_float.zig
 | 
1
+
M
lib/std/fmt/parse_float/parse.zig
 | 
2
++

2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/lib/std/fmt/parse_float.zig b/lib/std/fmt/parse_float.zig
@@ -119,6 +119,7 @@ test "fmt.parseFloat hex.f16" {
 }
 
 test "fmt.parseFloat hex.f32" {
+    try testing.expectError(error.InvalidCharacter, parseFloat(f32, "0x"));
     try testing.expectEqual(try parseFloat(f32, "0x1p0"), 1.0);
     try testing.expectEqual(try parseFloat(f32, "-0x1p-1"), -0.5);
     try testing.expectEqual(try parseFloat(f32, "0x10p+10"), 16384.0);
diff --git a/lib/std/fmt/parse_float/parse.zig b/lib/std/fmt/parse_float/parse.zig
@@ -107,6 +107,8 @@ fn parsePartialNumberBase(comptime T: type, stream: *FloatStream, negative: bool
     tryParseDigits(MantissaT, stream, &mantissa, info.base);
     var int_end = stream.offsetTrue();
     var n_digits = @intCast(isize, stream.offsetTrue());
+    // the base being 16 implies a 0x prefix, which shouldn't be included in the digit count
+    if (info.base == 16) n_digits -= 2;
 
     // handle dot with the following digits
     var exponent: i64 = 0;