motiejus/zig
1
Fork 0
Code Releases Activity

std.posix: handle INVAL in openZ and openatZ

Browse Source 
Contributes to #15607

Although the case is not handled in `openatWasi` (as I could not get a
working wasi environment to test the change) I have added a FIXME
addressing it and linking to the issue.
This commit is contained in:
Ketan Reynolds
2024-05-01 21:00:33 +02:00
committed by Ryan Liptak
parent c157550928
commit b4e7b6fdba
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/std/posix.zig
View File

@@ -1598,7 +1598,7 @@ pub fn openZ(file_path: [*:0]const u8, flags: O, perm: mode_t) OpenError!fd_t {
.INTR => continue,
.FAULT => unreachable,
.INVAL => unreachable,
.INVAL => return error.BadPathName,
.ACCES => return error.AccessDenied,
.FBIG => return error.FileTooBig,
.OVERFLOW => return error.FileTooBig,
@@ -1676,6 +1676,9 @@ pub fn openatWasi(
.INTR => continue,
.FAULT => unreachable,
// FIXME: It is worth looking into returning a `error.BadPathName`
// here if wasi follows other posix behavior
// see: https://github.com/ziglang/zig/issues/15607
.INVAL => unreachable,
.BADF => unreachable,
.ACCES => return error.AccessDenied,
@@ -1767,7 +1770,7 @@ pub fn openatZ(dir_fd: fd_t, file_path: [*:0]const u8, flags: O, mode: mode_t) O
.INTR => continue,
.FAULT => unreachable,
.INVAL => unreachable,
.INVAL => return error.BadPathName,
.BADF => unreachable,
.ACCES => return error.AccessDenied,
.FBIG => return error.FileTooBig,