commit be0a77efd2aad5108d3357914cbc71f560ea0161 (tree)
parent 073ef0f393ff4297e8d48a72f30a605c2d272289
Author: Matthew Lugg <mlugg@mlugg.co.uk>
Date: Tue, 6 Jan 2026 11:13:13 +0000
std: re-enable some disabled tests
I believe these tests may have been flaky as a result of the bug fixed
in the previous commit. A big hint is that they were all crashing with
SIGSEGV with no stack trace. I suspect that some lingering SIGIOs from
cancelations were being delivered to a thread after its `munmap` call,
which was happening because the test runner called `Io.Threaded.deinit`
to cause all of the (detached) worker threads to exit.
If this passes, I'll re-run the x86_64-linux CI jobs on this commit a
few times before merge to try and be sure there are no lingering
failures.
Resolves: https://codeberg.org/ziglang/zig/issues/30096
Resolves: https://codeberg.org/ziglang/zig/issues/30592
Resolves: https://codeberg.org/ziglang/zig/issues/30682
Diffstat:
2 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/lib/std/Io/test.zig b/lib/std/Io/test.zig
@@ -254,8 +254,6 @@ test "Group.cancel" {
}
test "Group.concurrent" {
- if (builtin.os.tag == .linux and !builtin.link_libc) return error.SkipZigTest; // https://codeberg.org/ziglang/zig/issues/30096
-
const io = testing.io;
var group: Io.Group = .init;
@@ -421,8 +419,6 @@ test "Event" {
}
test "recancel" {
- if (builtin.os.tag == .linux and !builtin.link_libc) return error.SkipZigTest; // https://codeberg.org/ziglang/zig/issues/30592
-
const global = struct {
fn worker(io: Io) Io.Cancelable!void {
var dummy_event: Io.Event = .unset;
diff --git a/lib/std/crypto/argon2.zig b/lib/std/crypto/argon2.zig
@@ -907,8 +907,6 @@ test "kdf" {
}
test "phc format hasher" {
- if (true) return error.SkipZigTest; // https://codeberg.org/ziglang/zig/issues/30682
-
const allocator = std.testing.allocator;
const password = "testpass";
const io = std.testing.io;