zig

commit c0fe135ff3ec09c71103f382cdca60506b557e57 (tree)
parent 10b56b21d4f37f7a79562deb3bc6a53ce6da0eb0
Author: Luuk de Gram <luuk@degram.dev>
Date:   Tue, 18 Oct 2022 17:20:08 +0200

test/link: remove redundant dependOn statements

`runAndCompare` will already depend on the `CheckObject` step itself
so it's not needed to also have the test step depend on the
check object step.

Diffstat:
M
test/link/macho/dead_strip/build.zig
 | 
2
--
M
test/link/macho/dylib/build.zig
 | 
2
--
M
test/link/macho/entry/build.zig
 | 
1
-
M
test/link/macho/needed_library/build.zig
 | 
1
-
M
test/link/macho/search_strategy/build.zig
 | 
1
-
M
test/link/macho/stack_size/build.zig
 | 
1
-
M
test/link/macho/weak_library/build.zig
 | 
2
--

7 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/test/link/macho/dead_strip/build.zig b/test/link/macho/dead_strip/build.zig
@@ -16,7 +16,6 @@ pub fn build(b: *Builder) void {
         const check = exe.checkObject(.macho);
         check.checkInSymtab();
         check.checkNext("{*} (__TEXT,__text) external _iAmUnused");
-        test_step.dependOn(&check.step);
 
         const run_cmd = check.runAndCompare();
         run_cmd.expectStdOutEqual("Hello!\n");
@@ -31,7 +30,6 @@ pub fn build(b: *Builder) void {
         const check = exe.checkObject(.macho);
         check.checkInSymtab();
         check.checkNotPresent("{*} (__TEXT,__text) external _iAmUnused");
-        test_step.dependOn(&check.step);
 
         const run_cmd = check.runAndCompare();
         run_cmd.expectStdOutEqual("Hello!\n");
diff --git a/test/link/macho/dylib/build.zig b/test/link/macho/dylib/build.zig
@@ -40,8 +40,6 @@ pub fn build(b: *Builder) void {
     check_exe.checkNext("current version 10000");
     check_exe.checkNext("compatibility version 10000");
 
-    test_step.dependOn(&check_exe.step);
-
     check_exe.checkStart("cmd RPATH");
     check_exe.checkNext(std.fmt.allocPrint(b.allocator, "path {s}", .{b.pathFromRoot("zig-out/lib")}) catch unreachable);
 
diff --git a/test/link/macho/entry/build.zig b/test/link/macho/entry/build.zig
@@ -26,7 +26,6 @@ pub fn build(b: *Builder) void {
     check_exe.checkNext("{n_value} (__TEXT,__text) external _non_main");
 
     check_exe.checkComputeCompare("vmaddr entryoff +", .{ .op = .eq, .value = .{ .variable = "n_value" } });
-    test_step.dependOn(&check_exe.step);
 
     const run = check_exe.runAndCompare();
     run.expectStdOutEqual("42");
diff --git a/test/link/macho/needed_library/build.zig b/test/link/macho/needed_library/build.zig
@@ -31,7 +31,6 @@ pub fn build(b: *Builder) void {
     const check = exe.checkObject(.macho);
     check.checkStart("cmd LOAD_DYLIB");
     check.checkNext("name @rpath/liba.dylib");
-    test_step.dependOn(&check.step);
 
     const run_cmd = check.runAndCompare();
     test_step.dependOn(&run_cmd.step);
diff --git a/test/link/macho/search_strategy/build.zig b/test/link/macho/search_strategy/build.zig
@@ -17,7 +17,6 @@ pub fn build(b: *Builder) void {
         const check = exe.checkObject(.macho);
         check.checkStart("cmd LOAD_DYLIB");
         check.checkNext("name @rpath/liba.dylib");
-        test_step.dependOn(&check.step);
 
         const run = check.runAndCompare();
         run.cwd = b.pathFromRoot(".");
diff --git a/test/link/macho/stack_size/build.zig b/test/link/macho/stack_size/build.zig
@@ -18,7 +18,6 @@ pub fn build(b: *Builder) void {
     const check_exe = exe.checkObject(.macho);
     check_exe.checkStart("cmd MAIN");
     check_exe.checkNext("stacksize 100000000");
-    test_step.dependOn(&check_exe.step);
 
     const run = check_exe.runAndCompare();
     test_step.dependOn(&run.step);
diff --git a/test/link/macho/weak_library/build.zig b/test/link/macho/weak_library/build.zig
@@ -33,8 +33,6 @@ pub fn build(b: *Builder) void {
     check.checkNext("(undefined) weak external _a (from liba)");
     check.checkNext("(undefined) weak external _asStr (from liba)");
 
-    test_step.dependOn(&check.step);
-
     const run_cmd = check.runAndCompare();
     run_cmd.expectStdOutEqual("42 42");
     test_step.dependOn(&run_cmd.step);