zig

commit c13355abda21e90443ae9ea59706e491111a8bcb (tree)
parent a689c3819777c7ebbf00f752951a9a69c7a44c8e
Author: Alex Rønne Petersen <alex@alexrp.com>
Date:   Mon, 20 Oct 2025 03:44:51 +0200

std.debug: fix FP unwind progress check for stackGrowth() == .up targets

Diffstat:
M
lib/std/debug.zig
 | 
10
+++++++---

1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/lib/std/debug.zig b/lib/std/debug.zig
@@ -974,11 +974,15 @@ const StackIterator = union(enum) {
                 const ra_ptr: *const usize = @ptrFromInt(ra_addr);
                 const bp = applyOffset(bp_ptr.*, stack_bias) orelse return .end;
 
-                // The stack grows downards, so `bp > fp` should always hold. If it doesn't, this
-                // frame is invalid, so we'll treat it as though it we reached end of stack. The
+                // If the stack grows downwards, `bp > fp` should always hold; conversely, if it
+                // grows upwards, `bp < fp` should always hold. If that is not the case, this
+                // frame is invalid, so we'll treat it as though we reached end of stack. The
                 // exception is address 0, which is a graceful end-of-stack signal, in which case
                 // *this* return address is valid and the *next* iteration will be the last.
-                if (bp != 0 and bp <= fp) return .end;
+                if (bp != 0 and switch (comptime builtin.target.stackGrowth()) {
+                    .down => bp <= fp,
+                    .up => bp >= fp,
+                }) return .end;
 
                 it.fp = bp;
                 const ra = stripInstructionPtrAuthCode(ra_ptr.*);