zig

commit c44be99f1abff2ab67d69964efecca380b96219e (tree)
parent 4de2b1ea65e6b54cedfe56268a8bf8e9446addb0
Author: Michael Dusan <michael.dusan@gmail.com>
Date:   Thu, 30 Jan 2025 09:27:32 -0500

debug: fix MemoryAccessor file leak

- patch authored by Jacob Young
- tested on alpine-aarch64, 3.21.0, qemu-system 9.2.0
- issue manifested on Alpine Linux aarch64 under qemu-system where
  zig2 fails during bootstrap: error.ProcessFdQuotaExceeded

Diffstat:
M
lib/std/debug.zig
 | 
1
+
M
lib/std/debug/MemoryAccessor.zig
 | 
11
+++++++++++

2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/lib/std/debug.zig b/lib/std/debug.zig
@@ -775,6 +775,7 @@ pub const StackIterator = struct {
     }
 
     pub fn deinit(it: *StackIterator) void {
+        it.ma.deinit();
         if (have_ucontext and it.unwind_state != null) it.unwind_state.?.dwarf_context.deinit();
     }
 
diff --git a/lib/std/debug/MemoryAccessor.zig b/lib/std/debug/MemoryAccessor.zig
@@ -25,6 +25,17 @@ pub const init: MemoryAccessor = .{
     },
 };
 
+pub fn deinit(ma: *MemoryAccessor) void {
+    switch (native_os) {
+        .linux => switch (ma.mem.handle) {
+            -2, -1 => {},
+            else => ma.mem.close(),
+        },
+        else => {},
+    }
+    ma.* = undefined;
+}
+
 fn read(ma: *MemoryAccessor, address: usize, buf: []u8) bool {
     switch (native_os) {
         .linux => while (true) switch (ma.mem.handle) {