zig

commit c6fbe0d5d89a7b2665a0afa7fad23027fd0b87ca (tree)
parent 6dc1fafe9882bdfb063c9bc02149c4a97fcaa2b5
Author: Robin Voetter <robin@voetter.nl>
Date:   Fri, 25 Nov 2022 14:58:14 +0100

dont destroy old bin file on link openpath failure

This was causing some crashes.

Diffstat:
M
src/Compilation.zig
 | 
3
++-

1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/Compilation.zig b/src/Compilation.zig
@@ -1948,8 +1948,9 @@ pub fn update(comp: *Compilation, main_progress_node: *std.Progress.Node) !void 
                 .sub_path = std.fs.path.basename(sub_path),
             };
         }
-        comp.bin_file.destroy();
+        var old_bin_file = comp.bin_file;
         comp.bin_file = try link.File.openPath(comp.gpa, options);
+        old_bin_file.destroy();
     }
 
     // For compiling C objects, we rely on the cache hash system to avoid duplicating work.