zig

commit cb026c5d599dddc38f34ee93438d52bbffe2f6ad (tree)
parent 255737ea572f437afb1f2ad67096d3a157d79d70
Author: Robin Voetter <robin@voetter.nl>
Date:   Tue, 21 Nov 2023 19:58:29 +0100

spirv: always emit mask constants even if no bits are set

A parameter like this is not always optional, even if that is
usually implied. SPIR-V tools fail to parse a module with an
OpLoopMerge instruction where the loop control parameter is
left out.

Diffstat:
M
src/codegen/spirv/Section.zig
 | 
7
-------

1 file changed, 0 insertions(+), 7 deletions(-)
diff --git a/src/codegen/spirv/Section.zig b/src/codegen/spirv/Section.zig
@@ -198,10 +198,6 @@ fn writeExtendedMask(section: *Section, comptime Operand: type, operand: Operand
         }
     }
 
-    if (mask == 0) {
-        return;
-    }
-
     section.writeWord(mask);
 
     inline for (@typeInfo(Operand).Struct.fields) |field| {
@@ -304,9 +300,6 @@ fn extendedMaskSize(comptime Operand: type, operand: Operand) usize {
             else => unreachable,
         }
     }
-    if (!any_set) {
-        return 0;
-    }
     return total + 1; // Add one for the mask itself.
 }