zig

commit db3b517639db2f4abd3b06a249e95a5e18599126 (tree)
parent ff5673ae1b74b8ad59ee23921e0bb4e25349d10f
Author: Andrew Kelley <superjoe30@gmail.com>
Date:   Fri,  5 Feb 2016 14:49:01 -0700

Merge branch 'realazthat-nonnull-branch'

Diffstat:
M
src/codegen.cpp
 | 
4
++--
M
src/zig_llvm.cpp
 | 
10
++++++++++
M
src/zig_llvm.hpp
 | 
2
++

3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/codegen.cpp b/src/codegen.cpp
@@ -2876,6 +2876,7 @@ static void do_code_gen(CodeGen *g) {
         if (handle_is_ptr(fn_type->data.fn.fn_type_id.return_type)) {
             LLVMValueRef first_arg = LLVMGetParam(fn_table_entry->fn_value, 0);
             LLVMAddAttribute(first_arg, LLVMStructRetAttribute);
+            LLVMZigAddNonNullAttr(fn_table_entry->fn_value, 1);
         }
 
         // set parameter attributes
@@ -2903,8 +2904,7 @@ static void do_code_gen(CodeGen *g) {
                 LLVMAddAttribute(argument_val, LLVMReadOnlyAttribute);
             }
             if (param_type->id == TypeTableEntryIdPointer) {
-                // when https://github.com/andrewrk/zig/issues/82 is fixed, add
-                // non null attribute here
+                LLVMZigAddNonNullAttr(fn_table_entry->fn_value, gen_index + 1);
             }
             if (is_byval) {
                 // TODO
diff --git a/src/zig_llvm.cpp b/src/zig_llvm.cpp
@@ -140,6 +140,16 @@ LLVMValueRef LLVMZigBuildCall(LLVMBuilderRef B, LLVMValueRef Fn, LLVMValueRef *A
     return wrap(unwrap(B)->Insert(call_inst));
 }
 
+void LLVMZigAddNonNullAttr(LLVMValueRef fn, unsigned i)
+{
+    assert( isa<Function>(unwrap(fn)) );
+
+    Function *unwrapped_function = reinterpret_cast<Function*>(unwrap(fn));
+
+    unwrapped_function->addAttribute(i, Attribute::NonNull);
+}
+
+
 LLVMZigDIType *LLVMZigCreateDebugPointerType(LLVMZigDIBuilder *dibuilder, LLVMZigDIType *pointee_type,
         uint64_t size_in_bits, uint64_t align_in_bits, const char *name)
 {
diff --git a/src/zig_llvm.hpp b/src/zig_llvm.hpp
@@ -39,6 +39,8 @@ void LLVMZigOptimizeModule(LLVMTargetMachineRef targ_machine_ref, LLVMModuleRef 
 LLVMValueRef LLVMZigBuildCall(LLVMBuilderRef B, LLVMValueRef Fn, LLVMValueRef *Args,
         unsigned NumArgs, unsigned CC, const char *Name);
 
+// 0 is return value, 1 is first arg
+void LLVMZigAddNonNullAttr(LLVMValueRef fn, unsigned i);
 
 LLVMZigDIType *LLVMZigCreateDebugPointerType(LLVMZigDIBuilder *dibuilder, LLVMZigDIType *pointee_type,
         uint64_t size_in_bits, uint64_t align_in_bits, const char *name);