stage2: handle truncate to signed non-pow-two integers

This commit is contained in:
Jakub Konka
2022-02-10 11:27:38 +01:00
parent c10fdde5a6
commit e139c41fd8
2 changed files with 34 additions and 14 deletions

View File

@@ -958,16 +958,17 @@ fn airTrunc(self: *Self, inst: Air.Inst.Index) !void {
return self.fail("TODO implement trunc for abi sizes larger than 8", .{});
}
const dst_mcv = blk: {
const reg = switch (operand) {
.register => |reg| reg,
else => inner: {
const reg = try self.register_manager.allocReg(inst);
try self.genSetReg(src_ty, reg, operand);
break :inner reg;
},
};
break :blk .{ .register = registerAlias(reg, @intCast(u32, dst_ty_size)) };
operand.freezeIfRegister(&self.register_manager);
defer operand.unfreezeIfRegister(&self.register_manager);
const reg: Register = blk: {
if (operand.isRegister()) {
if (self.reuseOperand(inst, ty_op.operand, 0, operand)) {
break :blk operand.register;
}
}
const mcv = try self.copyToNewRegister(inst, src_ty, operand);
break :blk mcv.register.to64();
};
// when truncating a `u16` to `u5`, for example, those top 3 bits in the result
@@ -975,11 +976,31 @@ fn airTrunc(self: *Self, inst: Air.Inst.Index) !void {
const dst_bit_size = dst_ty.bitSize(self.target.*);
const is_power_of_two = (dst_bit_size & (dst_bit_size - 1)) == 0;
if (!is_power_of_two or dst_bit_size < 8) {
const mask = (~@as(u64, 0)) >> @intCast(u6, (64 - dst_ty.bitSize(self.target.*)));
try self.genBinMathOpMir(.@"and", dst_ty, dst_mcv, .{ .immediate = mask });
const shift = @intCast(u6, 64 - dst_ty.bitSize(self.target.*));
const mask = (~@as(u64, 0)) >> shift;
try self.genBinMathOpMir(.@"and", Type.usize, .{ .register = reg }, .{ .immediate = mask });
if (src_ty.intInfo(self.target.*).signedness == .signed) {
_ = try self.addInst(.{
.tag = .sal,
.ops = (Mir.Ops{
.reg1 = reg,
.flags = 0b10,
}).encode(),
.data = .{ .imm = shift },
});
_ = try self.addInst(.{
.tag = .sar,
.ops = (Mir.Ops{
.reg1 = reg,
.flags = 0b10,
}).encode(),
.data = .{ .imm = shift },
});
}
}
return self.finishAir(inst, dst_mcv, .{ ty_op.operand, .none, .none });
return self.finishAir(inst, .{ .register = reg }, .{ ty_op.operand, .none, .none });
}
fn airBoolToInt(self: *Self, inst: Air.Inst.Index) !void {

View File

@@ -26,7 +26,6 @@ fn testTruncate(x: u32) u8 {
test "truncate to non-power-of-two integers" {
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
try testTrunc(u32, u1, 0b10101, 0b1);
try testTrunc(u32, u1, 0b10110, 0b0);