commit e42e12dbbf8ebae65589ff08c3b5a454d2d67441 (tree)
parent 6756aaccf14e168132cabe8e0d7933f4fd51e9a9
Author: Jakub Konka <kubkon@jakubkonka.com>
Date: Thu, 4 Jul 2024 22:03:31 +0200
tsan: fix wording in comments
Diffstat:
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/libtsan.zig b/src/libtsan.zig
@@ -27,9 +27,8 @@ pub fn buildTsan(comp: *Compilation, prog_node: std.Progress.Node) BuildError!vo
const target = comp.getTarget();
const root_name = switch (target.os.tag) {
- // On Apple platforms, we use the same name as LLVM and Apple so that we correctly
- // mark the images as instrumented when traversing them when TSAN dylib is
- // initialized.
+ // On Apple platforms, we use the same name as LLVM because the
+ // TSAN library implementation hard-codes a check for these names.
.macos => "clang_rt.tsan_osx_dynamic",
.ios => switch (target.abi) {
.simulator => "clang_rt.tsan_iossim_dynamic",
@@ -290,7 +289,7 @@ pub fn buildTsan(comp: *Compilation, prog_node: std.Progress.Node) BuildError!vo
try std.fmt.allocPrintZ(arena, "@rpath/{s}", .{basename})
else
null;
- // This is temp conditional on resolving https://github.com/llvm/llvm-project/issues/97627 upstream.
+ // Workaround for https://github.com/llvm/llvm-project/issues/97627
const headerpad_size: ?u32 = if (target.isDarwin()) 32 else null;
const sub_compilation = Compilation.create(comp.gpa, arena, .{
.local_cache_directory = comp.global_cache_directory,