motiejus/zig
1
Fork 0
Code Releases Activity

fix accidental quadratic dependence on haystack length in replace and replacementSize (#8859)

Browse Source
This commit is contained in:
Matthew Borkowski
2021-05-22 04:55:28 -04:00
committed by GitHub
parent 4b69bd61e4
commit f4101c1153
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/std/mem.zig
View File

@@ -2074,7 +2074,7 @@ pub fn replace(comptime T: type, input: []const T, needle: []const T, replacemen
var slide: usize = 0;
var replacements: usize = 0;
while (slide < input.len) {
if (mem.indexOf(T, input[slide..], needle) == @as(usize, 0)) {
if (mem.startsWith(T, input[slide..], needle)) {
mem.copy(T, output[i .. i + replacement.len], replacement);
i += replacement.len;
slide += needle.len;
@@ -2129,7 +2129,7 @@ pub fn replacementSize(comptime T: type, input: []const T, needle: []const T, re
var i: usize = 0;
var size: usize = input.len;
while (i < input.len) {
if (mem.indexOf(T, input[i..], needle) == @as(usize, 0)) {
if (mem.startsWith(T, input[i..], needle)) {
size = size - needle.len + replacement.len;
i += needle.len;
} else {